Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eat your own dog food (use deptrac on deptrac) #645

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Eat your own dog food (use deptrac on deptrac) #645

merged 1 commit into from
Jul 26, 2021

Conversation

patrickkusebauch
Copy link
Collaborator

@patrickkusebauch patrickkusebauch commented Jul 22, 2021

Use deptrac to analyse deptrac.

@patrickkusebauch patrickkusebauch marked this pull request as draft July 22, 2021 16:43
@patrickkusebauch
Copy link
Collaborator Author

I came up with this:
test

  • Console: Input/output of the tool. Split up Formatters for both more control and to show off GraphViz groups functionality
  • Application: Entrypoint of the application. The endpoint of the console commands and routing to the rest of the domains
  • Resolver: Resolves dependencies into layers
  • Dependencies: Immutable dependency classes describing the dependencies
  • AstRunner: Parses the files and creates the AstTree for Resolver to resolve into dependencies
  • Events: Event system for informing about the progress in the console

From this image, you can see a few places where it would be IMHO valuable to do a little refactor and reparate the domains a little bit better.

Also, from the depfile.yaml you can see that the configuration for some of the layers is really convoluted and therefore might be valuable to move some classes a bit if we decide this is a reasonable slit of the domains.

@patrickkusebauch patrickkusebauch marked this pull request as ready for review July 23, 2021 19:59
@patrickkusebauch patrickkusebauch changed the title WIP: Eat your own dog food Eat your own dog food (use deptrac on deptrac) Jul 23, 2021
@dbrumann dbrumann merged commit 99bb10d into qossmic:main Jul 26, 2021
@patrickkusebauch patrickkusebauch deleted the dogfood branch July 26, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants