Debug commands #647
Merged
Debug commands #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $classLikeName = $classReference->getTokenName(); | ||
| if ([] === $classLikeLayerResolver->getLayersByTokenName($classLikeName)) { | ||
| $classLikeNames[] = $classLikeName->toString(); | ||
| foreach ($astMap->getAstFileReferences() as $fileReference) { |
There was a problem hiding this comment.
This is an extension of the current functionality. But I am thinking if this should first pass by Emitters somehow since now you might not want to collect some of the tokens. Something like to actually analyze normally, and look at the dependencyResult for dependencies that are not in any layer.
There was a problem hiding this comment.
That's a good idea, but we can defer it to a separate PR.
dbrumann
approved these changes
Aug 3, 2021
| $classLikeName = $classReference->getTokenName(); | ||
| if ([] === $classLikeLayerResolver->getLayersByTokenName($classLikeName)) { | ||
| $classLikeNames[] = $classLikeName->toString(); | ||
| foreach ($astMap->getAstFileReferences() as $fileReference) { |
There was a problem hiding this comment.
That's a good idea, but we can defer it to a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #638