Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support php 8.1 #681

Merged
merged 1 commit into from
Sep 1, 2021
Merged

feat: support php 8.1 #681

merged 1 commit into from
Sep 1, 2021

Conversation

shouze
Copy link

@shouze shouze commented Aug 31, 2021

This is my 1st contribution to this project so I'm no sure I'm doing right:

  1. Should I also add an entry in the changelog?
  2. How does the publication into https://github.com/qossmic/deptrac-shim work?

@@ -17,7 +17,7 @@
}
],
"require": {
"php": "^7.4.0 || 8.0.*",
"php": "^7.4.0 || 8.0.* || 8.1.*",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you prefer instead

Suggested change
"php": "^7.4.0 || 8.0.* || 8.1.*",
"php": "^7.4.0 || ^8.0.0",

@patrickkusebauch
Copy link
Collaborator

This is my 1st contribution to this project so I'm no sure I'm doing right:

  1. Should I also add an entry in the changelog?
  2. How does the publication into https://github.com/qossmic/deptrac-shim work?
  1. No need, this is done automatically upon release from all the commits since the last release.
  2. @dbrumann takes care of that for each release, so you don't have to worry about it.

@dbrumann
Copy link
Collaborator

dbrumann commented Sep 1, 2021

Thanks a lot.

@dbrumann dbrumann merged commit fdbca7e into qossmic:main Sep 1, 2021
@shouze shouze deleted the feat-support-php-81 branch September 1, 2021 09:53
@shouze
Copy link
Author

shouze commented Sep 1, 2021

@dbrumann
Copy link
Collaborator

dbrumann commented Sep 1, 2021

Yes, I forgot to run the tests first. Not a big deal, though. We can allow PHP 8.1 to fail for now and then fix the issues.

I will have a look at it later.

@shouze shouze mentioned this pull request Sep 1, 2021
@shouze
Copy link
Author

shouze commented Sep 1, 2021

Yes, I forgot to run the tests first. Not a big deal, though. We can allow PHP 8.1 to fail for now and then fix the issues.

I will have a look at it later.

Almost good in #685 except 2 things:

  1. I don't know why infection is now broken with php 7.4
  2. Those warnings in phpunit, ain't easy to fix because this prophecy trait looks to be not included into phpunit.phar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants