-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor application configuration #706
Conversation
860735f
to
d47cd49
Compare
@dbrumann if this is meant to be BC break (and thus requiring a new major version if keeping semanting versioning), can other BC breaks like removing deprecated parameters be released alongside this refactor? Not this PR per se, in order not to clutter, but with the new release version? |
Since we are still in |
d47cd49
to
06ecad8
Compare
217a28a
to
73ec47a
Compare
37aae31
to
fb54cf7
Compare
5d8616d
to
880520a
Compare
fd9b182
to
206570f
Compare
9401e82
to
4e284fb
Compare
* Default filename changes to "deptrac.yaml" * Config now live under parameters-section (except for imports) * Docs updated * Command issues warning when old file is detected * Loader triggers deprecation when old config is encountered
4e284fb
to
e52db9c
Compare
Background
As discussed before, having some kind of extension mechanism for Deptrac would be nice, e.g. to register custom collectors or output formatters. This will require some changes to the application bootstrapping and configuration.
Description
I am moving the current configuration to the parameters section to make it easier to reuse them in services and to be in line with how Symfony configures services.
To Dos
--config-file
from Application instead of current depfile argumentFollow ups
deptrac.collector
(Allows adding new collectors by tagging them)deptrac.formatter