Depfile use output instead of symfony #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrumann
commented
Dec 10, 2021
| - Qossmic\Deptrac\AstRunner\AstMap\AstInherit | ||
| Qossmic\Deptrac\LayerAnalyser: | ||
| - Qossmic\Deptrac\AstRunner\AstRunner | ||
| Qossmic\Deptrac\OutputFormatter\TableOutputFormatter: |
There was a problem hiding this comment.
Sorry for making it hard to read this change, but I tested #747 on this. This is the new addition to the baseline. The TableOutputFormatter relies on the TableSeparator from Symfony Console.
dbrumann
force-pushed
the
depfile_use_output_instead_of_symfony
branch
from
90ca658
to
443d12f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors ConsoleSubscriber to ensure it uses our own Output object instead of relying on Symfony\Console\Output