Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor of output formatters #754

Merged
merged 9 commits into from
Dec 12, 2021
Merged

Refactor of output formatters #754

merged 9 commits into from
Dec 12, 2021

Conversation

patrickkusebauch
Copy link
Collaborator

@patrickkusebauch patrickkusebauch commented Dec 11, 2021 •
edited
Loading

BC break by changing the arguments of Analyze commands and by splitting the GraphViz output formatters.

TODOs:

  • Documantation update
  • Clean-up of the code?

@patrickkusebauch patrickkusebauch marked this pull request as draft December 11, 2021 18:12
@patrickkusebauch patrickkusebauch marked this pull request as ready for review December 11, 2021 18:37
dbrumann
dbrumann approved these changes Dec 12, 2021
View reviewed changes
Copy link
Collaborator

@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@dbrumann dbrumann merged commit 30f2a9d into qossmic:main Dec 12, 2021
@patrickkusebauch patrickkusebauch deleted the feature/output-refactor branch December 12, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrumann dbrumann dbrumann approved these changes

Assignees
No one assigned
Labels
bc-break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patrickkusebauch @dbrumann