Update php-cs-fixer rules #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrumann
force-pushed
the
cs_fix_rules
branch
from
b47e947
to
3eadc5e
Compare
|
I will leave this open for a while in case anyone has suggestions for other cs rules to change while we are at it or if there are any objections to the changes. Looking especially at you @staabm and @patrickkusebauch 😉 |
staabm
approved these changes
Dec 17, 2021
| 'self_static_accessor' => true, | ||
| 'global_namespace_import' => [ |
There was a problem hiding this comment.
I usually do false, false, true, since everything apart of classes do not need the leading \ and it results in the smallest possible file.
But that is my personal preference.
patrickkusebauch
approved these changes
Dec 18, 2021
* Ensure consistent array indentation * Always import classes, functions and constants * Rearrange use statements alphabetically in groups * Use octal notation
dbrumann
force-pushed
the
cs_fix_rules
branch
from
3eadc5e
to
6ced80a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was annoyed by the (for my taste) weirdly arranged use statements and some minor inconsistencies, so I updated the rules. Sorry, if this causes some inconvenience for open PRs.
Updated rules:
use modern string methods likeWe don't have Symfony's polyfill and I don't want to add it for the 1 change caused by this rulestr_starts_withwhen possible