Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #715 #776

Merged
merged 5 commits into from
Jan 11, 2022
Merged

Resolves #715 #776

merged 5 commits into from
Jan 11, 2022

Conversation

patrickkusebauch
Copy link
Collaborator

@patrickkusebauch patrickkusebauch commented Dec 31, 2021 •
edited
Loading

Resolves #715

dbrumann
dbrumann reviewed Jan 6, 2022
View reviewed changes
composer.json Show resolved Hide resolved
@dbrumann dbrumann mentioned this pull request Jan 6, 2022
Closed
@dbrumann
Copy link
Collaborator

Do you want to rebase this PR before I prepare a 0.19 release or is it ok to leave this open for now?

@patrickkusebauch
Copy link
Collaborator Author

Do you want to rebase this PR before I prepare a 0.19 release or is it ok to leave this open for now?

I will rebase it today.

@patrickkusebauch patrickkusebauch marked this pull request as draft January 11, 2022 16:56
@patrickkusebauch patrickkusebauch marked this pull request as ready for review January 11, 2022 18:45
@patrickkusebauch
Copy link
Collaborator Author

patrickkusebauch commented Jan 11, 2022 •
edited
Loading

We should really consider "larger" refactor where we use DataCrate classes instead of arrays for passing stuff around. With @psalm-immutable they could even have public properties and no methods and be really lightweight.

@dbrumann dbrumann merged commit 197f196 into qossmic:main Jan 11, 2022
@patrickkusebauch patrickkusebauch deleted the feature/sa branch January 11, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrumann dbrumann dbrumann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix errors for new level introduced by phpstan 1.0
2 participants
@patrickkusebauch @dbrumann