Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix performance issue #799

Merged
merged 1 commit into from
Jan 23, 2022
Merged

Fix performance issue #799

merged 1 commit into from
Jan 23, 2022

Conversation

pincher2012
Copy link

@pincher2012 pincher2012 commented Jan 20, 2022 •
edited
Loading

Closes #798

real    0m8,316s
user    0m7,007s
sys     0m1,129s

versus vanila 0.19.1

real    7m38,165s
user    7m32,888s
sys     0m1,887s

@pincher2012 pincher2012 force-pushed the fix-fqdn-performance-issue branch 8 times, most recently from aab743d to 1218179 Compare January 21, 2022 00:57
pincher2012
pincher2012 commented Jan 22, 2022
View reviewed changes
tests/DependencyEmitter/UsesDependencyEmitterTest.php
@@ -59,4 +59,19 @@ public function testIncludesFQDNWhichIsAlsoANamespacePrefix(): void
self::assertCount(1, $deps);
self::assertContains('FQDNNamespacePrefix\Uses\Foo:5 on FQDNNamespacePrefix\FQDN', $deps);
}

public function testIncludesFQDNWhichIsDoesNotExistAndSubstringOfAnotherFQDN(): void
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a case that shows the difference between main and my PR. This test will fail on main branch.

patrickkusebauch
patrickkusebauch approved these changes Jan 22, 2022
View reviewed changes
Copy link
Collaborator

@patrickkusebauch patrickkusebauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

dbrumann
dbrumann approved these changes Jan 23, 2022
View reviewed changes
Copy link
Collaborator

@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I will prepare a release with this fix later today

@dbrumann dbrumann merged commit c7681af into qossmic:main Jan 23, 2022
@pincher2012 pincher2012 deleted the fix-fqdn-performance-issue branch January 24, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickkusebauch patrickkusebauch patrickkusebauch approved these changes

@dbrumann dbrumann dbrumann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance issue
3 participants
@pincher2012 @patrickkusebauch @dbrumann