Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update collector keys #826

Merged
merged 1 commit into from Apr 1, 2022
Merged

Update collector keys #826

merged 1 commit into from Apr 1, 2022

Conversation

patrickkusebauch
Copy link
Collaborator

Closes #800

dbrumann
dbrumann approved these changes Mar 6, 2022
View reviewed changes
Copy link
Collaborator

@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, as always. Thank you 👍

@patrickkusebauch
Copy link
Collaborator Author

@dbrumann What do you want to do about the mutation testing failing? I did not write any new tests, but just by the fact of merging all the keys having the same name, there is more chance for mutations to fail.

@dbrumann
Copy link
Collaborator

dbrumann commented Apr 1, 2022

Sorry for the long wait. We will solve this in a follow up, by adjusting the mutation score.

@dbrumann dbrumann merged commit 104204b into qossmic:main Apr 1, 2022
@patrickkusebauch patrickkusebauch deleted the feature/collectorName branch April 1, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrumann dbrumann dbrumann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align collector configuration
2 participants
@patrickkusebauch @dbrumann