New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration overhaul #860
Conversation
dbrumann
commented
Apr 12, 2022
•
edited
edited
- Clarifies and introduces intended extension points (still experimental and work in progress!)
- Changes namespaces and class names:
- AstRunner > Ast
- Collector > Layer\Collector
- DependencyEmitter > Dependency\Emitter
- RulesetEngine -> Result
- Events are moved into a shared directory src/Event/
- some classes were renamed and moved, e.g. file loading in Configuration is moved out into File instead
- Reduces configuration layer in favor of having the class using the config (arrays) verify and process them
- All configuration is now processed during container compilation allowing us to change how certain classes are collected and used (replace Registry with ContainerInterface).
50516df
to
b2d4f29
Compare
b2887c6
to
c29313f
Compare
I have 2 questions that are not really clear to me about how they would be done going forward. And it might just be me not familiar with the Symfony Configuration/Container builder process:
|
c29313f
to
2c211e5
Compare
Yes, you can still configure multiple formatters in the deptrac.yaml. We pick the right formatter using the FormatterProvider, much like we did before. Only that formatter will be instantiated during the analyse command all others are "dormant". So, this should not change the behavior. For extensions this has the benefit that you can now register a custom formatter requiring configuration, without having to register the configuration file in Deptrac (e.g. like with ConfigurationGraphviz or ConfigurationCodeclimate).
Yes, at least that's how it is intended. The |
d78a4bf
to
f9b6d85
Compare
f5dfb98
to
dccbda0
Compare
dccbda0
to
cdac2b9
Compare
cdac2b9
to
78bc016
Compare