Get rid of phive #881
Merged
Get rid of phive #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed checks are not using the changed workflow in this PR, that's why they are failing. |
| @@ -19,8 +19,8 @@ | |||
| "require": { | |||
| "php": "^7.4 || ^8.0", | |||
| "ext-json": "*", | |||
| "composer/xdebug-handler": "^3.0", | |||
There was a problem hiding this comment.
To make things work, I had to change some packages' versions. I have tested that they are still working as expected.
| @@ -15,6 +15,9 @@ var_dump($env->get('BAR')); | |||
| var_dump($env->get('TEST')); | |||
|
|
|||
| --EXPECT-- | |||
| Standard input code:7: | |||
There was a problem hiding this comment.
I guess this is what you meant when talking about the extra PHPUnit output. I tried to figure out what causes that, but in the end I said to myself that it doesn't really matter anyway.
dbrumann
approved these changes
May 19, 2022
|
Does this mean that Phive installation is no longer supported? Or is this just about this package using Phive? |
|
It's about this package using phive. You should still be able to install deptrac via phive yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #785