Make allowed layer resolution public #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrumann
reviewed
Jun 1, 2022
| @@ -38,7 +38,7 @@ public function __invoke(ProcessEvent $event): void | |||
|
|
|||
| foreach ($event->getDependentLayers() as $dependentLayer) { | |||
| try { | |||
| $allowedLayers = $this->getAllowedLayers($dependerLayer); | |||
| $allowedLayers = self::getAllowedLayers($dependerLayer, $this->allowedLayers); | |||
There was a problem hiding this comment.
I am not a big fan of using static methods as its harder to switch out their implementation in tests. Can we extract the logic into its own class instead? How about something like Qossmic\Deptrac\Analyser\LayerProvider or LayerResolver?
There was a problem hiding this comment.
Sure, I can do that. 😀
patrickkusebauch
force-pushed
the
feature/allowedDependencies
branch
from
e2927e8
to
5cdb255
Compare
dbrumann
approved these changes
Jun 1, 2022
|
@dbrumann is there something preventing the merge for this one? I need it to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making
AllowDependencyHandler::getAllowedLayerspublic and static. This helper method is useful for integrations.