Restore semantic configuration to allow deep merge on import

[dbrumann]

Restores semantic configuration for parameters:

• paths
• exclude_files
• layers
• ruleset
• skip_violations
• formatters
• analyser
• use_relative_path_from_depfile
• ignore_uncovered_internal_classes

but not for:

• projectDirectory
• depfileDirectory
• workingDirectory

Fixes #878

To Dos:

• Update documentation
• Update examples
• Check if imports works as expected again
• Check backwards compatibility

[patrickkusebauch]

Tried this branch on my repo and it had no effect. :(

[dbrumann]

@patrickkusebauch There was a problem where services were loaded after the extension. It should be better now.

I created a new example for imports docs/examples/imported_layers_deptrac.yaml based on docs/examples/DirectoryLayer.depfile.yaml. It's the same configuration but somehow still behaves differently. I am investigating what's causing this.

[dbrumann]

Turns out, I am just bad at copy & paste and Layer2 accidentally contained Layer1 classes. 😄

I still need to double check if I missed any parameters, but this should be good to go.

[patrickkusebauch]

I can test it later today if you'd like

[patrickkusebauch]

Listing issues as I encounter them:

Unrecognized option "count_use_statements" under "deptrac.analyser". Available option is "types".

[patrickkusebauch]

Unrecognized option "baseline" under "deptrac". Available options are "analyser", "exclude_files", "formatters", "ignore_uncovered_internal_classes", "layers", "paths", "ruleset", "skip_violations", "use_relative_path_from_depfile".

[patrickkusebauch]

Otherwise it is working.

[dbrumann]

Unrecognized option "count_use_statements" under "deptrac.analyser". Available option is "types".

I purposely didn't include it because it was deprecated anyway. If I remember correctly this option should be equivalent to this:

deptrac:
  analyzer:
    types: ['class']

Unrecognized option "baseline" under "deptrac".

This is equivalent to imports:, I'd prefer not to add baseline and use that instead.

Cannot autowire service "1": argument "$layers" of method "DanceEngineer\DeptracAwesome\UnusedDependenciesCommand::__construct()" is type-hinted "array", you should configure its value explicitly.

I don't see what's causing this. Can you give more details for this problem?

[patrickkusebauch]

Ad 1: Ok, that's fine. I had it there anyways just for legacy reasons
Ad 2: Sounds like a good idea. But it needs the corresponding docs.
Ad 3: That was my fault, it is a non-issue. I copied something incorrectly on my side.

[patrickkusebauch]

👍 LGTM

[WayneStilwell]

@dbrumann I'm super excited about this! Do you have an estimate of when version 0.21 will be released?