Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New collector for glob patterns #899

Merged
merged 1 commit into from Jun 4, 2022
Merged

New collector for glob patterns #899

merged 1 commit into from Jun 4, 2022

Conversation

dbrumann
Copy link
Collaborator

@dbrumann dbrumann commented Jun 4, 2022

Fixes #684

@dbrumann dbrumann marked this pull request as ready for review June 4, 2022 11:50
patrickkusebauch
patrickkusebauch approved these changes Jun 4, 2022
View reviewed changes
Copy link
Collaborator

@patrickkusebauch patrickkusebauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@dbrumann dbrumann merged commit 7efb92a into qossmic:main Jun 4, 2022
@dbrumann dbrumann deleted the glob_collector branch June 4, 2022 15:34
@rvanlaak
Copy link

rvanlaak commented Jun 9, 2022

Awesome implementation, it looks so much easier than I expected by using Symfony's toRegex support internally 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickkusebauch patrickkusebauch patrickkusebauch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add glob collector
3 participants
@dbrumann @rvanlaak @patrickkusebauch