Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution of template vars defined at function-like level #903

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Resolution of template vars defined at function-like level #903

merged 3 commits into from
Jun 23, 2022

Conversation

patrickkusebauch
Copy link
Collaborator

Fixes #667

@patrickkusebauch patrickkusebauch changed the title Resolution of template vars defined at function-like level. Resolution of template vars defined at function-like level Jun 7, 2022
Copy link
Collaborator

@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, that was a tricky one to wrap my head around. Another fantastic job, thanks.

@dbrumann dbrumann merged commit 38acf7f into qossmic:main Jun 23, 2022
@patrickkusebauch
Copy link
Collaborator Author

@dbrumann the jist of it is to add the template scope temporarily while inside the method/fuction and remove it again when the method closes.

@dbrumann
Copy link
Collaborator

Yep, after staring at the fixture file and test for a bit, I finally got it 😄

@patrickkusebauch patrickkusebauch deleted the feature/template_vars branch June 24, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template parameters inside functions/methods
2 participants