Fix init with existing file. #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrumann
commented
Sep 22, 2022
| @@ -30,7 +31,7 @@ public function dump(string $file): void | |||
| if ($filesystem->exists($target->getPathname())) { | |||
| throw FileAlreadyExistsException::alreadyExists($target); | |||
| } | |||
| if (!$target->isWritable()) { | |||
There was a problem hiding this comment.
FYI, a file that doesn't exist is never writable. Instead, we have to check the path (i.e. the directory containing the file), if it is writable, which is why this check never worked.
patrickkusebauch
suggested changes
Sep 22, 2022
dbrumann
force-pushed
the
fix_init_command
branch
3 times, most recently
from
e46d6bd
to
61c7560
Compare
Fixes qossmic#977 Closes qossmic#982
dbrumann
force-pushed
the
fix_init_command
branch
from
61c7560
to
81785c6
Compare
patrickkusebauch
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #977
Closes #982