Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes scripts from background section of google V3 manifest file #41

Merged
merged 2 commits into from
Apr 16, 2022

Conversation

power-spike
Copy link
Contributor

This is a small little update.

It adds in 'replace in file webpack plugin' - which allows you to update & modify files after webpack has created them.

What this does - is finding the manifest file under dist/chrome - and remove the scripts section on the build so you don't have to do it manually during the development phase.

  • Spike

@pbek
Copy link
Member

pbek commented Apr 16, 2022

Nice, I'm currently doing that in https://github.com/qownnotes/web-companion/blob/develop/build.sh, I guess I need to remove that and also update the uploaded file in

asset_path: packages/chrome.zip
to the original file.

@pbek pbek merged commit 11999f3 into qownnotes:develop Apr 16, 2022
@pbek
Copy link
Member

pbek commented Apr 16, 2022

Thank you!

@power-spike
Copy link
Contributor Author

NP At all, I found this repo while trying to work out how to do browser extensions. and remembered a comment about having to manually update the manifest file for chrome :)

The plugin is nice - and you can target files in directories - so you might be able to remove more items out of your build file as well :)

pbek added a commit that referenced this pull request Apr 16, 2022
pbek added a commit that referenced this pull request Apr 16, 2022
@pbek
Copy link
Member

pbek commented Dec 21, 2022

Strange, this didn't do anything for https://github.com/qownnotes/web-companion/releases/tag/v22.12.0. I'll have to enable my workaround in the build script again since the Chrome release is currently broken and Google denied the publication of the extension.

@pbek
Copy link
Member

pbek commented Dec 21, 2022

The "scripts": [] is removed in the manifest in the dist folder, but it isn't removed in the package in the packages folder.

pbek added a commit that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants