Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] some web clipper images are saved without an extension #51

Closed
azurew4r3 opened this issue May 2, 2023 · 5 comments
Closed

[BUG] some web clipper images are saved without an extension #51

azurew4r3 opened this issue May 2, 2023 · 5 comments
Labels

Comments

@azurew4r3
Copy link

azurew4r3 commented May 2, 2023

Platform: Windows 10
Browser: Vivaldi

Expected behaviour

linked images saved with valid filename and extension (ie: filename.png or filename.svg)

Actual behaviour

notes saved via chrome's web extension "Create note with screenshot of visible page" appends the image file name with a dot (without an extension)

 example:
 ![media-AtKGem](media/media-AtKGem.)

when viewing the "Manage stored images" panel, the image file name is displayed without the dot (and without an extension)

 example:
 media-AtKGem

with that difference, these images are listed as "orphaned"

Further testing to pinpoint issue:

Saving a page via chrome's web extension option "Send page .." does name images with a proper extension. As does insert image from the Edit menu.

these images are not listed as "orphaned"

Steps to reproduce

with "QOwnNotes Companion Browser Extension" installed

right click a web page
select "Create note with screenshot of visible page"
view the new note's image link within the Edit panel

Output from the debug section in the settings dialog in QOwnNotes

Relevant log output in the Log panel in QOwnNotes

@pbek
Copy link
Member

pbek commented May 2, 2023

I guess you are talking about a feature of qownnotes, can you please open an issue there?

@pbek pbek added the Support label May 2, 2023
@azurew4r3 azurew4r3 changed the title [BUG] orphan web clipper images [BUG] some web clipper images are saved without an extension May 2, 2023
@azurew4r3
Copy link
Author

I had started to post this as a QOwnNotes bug report. Then noticed this only happens with images from the web clipper. And more specifically, from the "Create note with screenshot .." option. So I aborted that report, and posted it here.

I could have worded the title better, can I edit that? It turns out I can! Please advise if this should still be moved, reposted over yonder.

@pbek
Copy link
Member

pbek commented May 2, 2023

If the image shows up for you in the note preview then an image was transferred correctly, everything else happens in QOwnNotes. So best open an issue there. I need more context (see issue template).

And I can't reproduce it neither, it doesn't show up for me...

image

@pbek
Copy link
Member

pbek commented May 2, 2023

After I deleted the note, the image was "orphaned" properly...

@azurew4r3
Copy link
Author

Ok will do, I will close this and re-post as QOwnNotes issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants