fix problems or otherwise improve code based on issues raised by Kloc…

…work git-svn-id: svn+q:///qpdf/trunk@690 71b93d88-0707-0410-a8cf-f5a4172ac649
qpdf · Sep 14, 2009 · 0ded90e · 0ded90e
1 parent b93c340
commit 0ded90e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/libqpdf/PCRE.cc b/libqpdf/PCRE.cc
@@ -147,7 +147,7 @@ PCRE::Match::nMatches() const
     return this->nmatches;
 }
 
-PCRE::PCRE(char const* pattern, int options) throw (Exception)
+PCRE::PCRE(char const* pattern, int options) throw (PCRE::Exception)
 {
     char const *errptr;
     int erroffset;

diff --git a/libqpdf/QPDF_linearization.cc b/libqpdf/QPDF_linearization.cc
@@ -113,19 +113,17 @@ QPDF::isLinearized()
 	}
 	else
 	{
-	    if ((p = (char*)memchr(p, '\0', tbuf_size - (p - buf))) != 0)
+	    p = (char*)memchr(p, '\0', tbuf_size - (p - buf));
+	    assert(p != 0);
+	    while ((p - buf < tbuf_size) && (*p == 0))
 	    {
-		QTC::TC("qpdf", "QPDF lindict null found");
-		while ((p - buf < tbuf_size) && (*p == 0))
-		{
-		    ++p;
-		}
-		if ((p - buf) == tbuf_size)
-		{
-		    break;
-		}
-		QTC::TC("qpdf", "QPDF lindict searching after null");
+		++p;
+	    }
+	    if ((p - buf) == tbuf_size)
+	    {
+		break;
 	    }
+	    QTC::TC("qpdf", "QPDF lindict searching after null");
 	}
     }
 

diff --git a/libtests/flate.cc b/libtests/flate.cc
@@ -15,6 +15,7 @@ FILE* safe_fopen(char const* filename, char const* mode)
     {
 	std::cerr << "fopen " << filename << " failed: " << strerror(errno)
 		  << std::endl;
+	exit(2);
     }
     return result;
 }

diff --git a/libtests/png_filter.cc b/libtests/png_filter.cc
@@ -15,6 +15,7 @@ FILE* safe_fopen(char const* filename, char const* mode)
     {
 	std::cerr << "fopen " << filename << " failed: " << strerror(errno)
 		  << std::endl;
+	exit(2);
     }
     return result;
 }