Merge pull request #244 from Abelarm/skip_S4_tests

[ENH] RCWA test are skipped if S4 not intalled

tests/conftest.py

@@ -229,3 +229,17 @@ def light_source(wavelength):
         output_units="photon_flux_per_m",
         concentration=1,
     )
+
+
+def skip_s4_test():
+    """
+     Utility function for skipping the test if S4 is not installed,
+
+    Returns: True if S4 not installed False otherwise
+    """
+
+    try:
+        import S4
+        return False
+    except ModuleNotFoundError:
+        return True

tests/test_optics.py

@@ -1,8 +1,8 @@
-import sys
+from .conftest import skip_s4_test
 from pytest import mark, approx
 
 
-@mark.skipif(sys.platform in ["win32", "cygwin"], reason="Only works under unix based  systems")
+@mark.skipif(skip_s4_test(), reason="Only works if S4 installed")
 def test_calculate_rat_rcwa():
     import numpy as np
 
@@ -32,7 +32,7 @@ def test_calculate_rat_rcwa():
         assert v.shape[0] == len(wl)
 
 
-@mark.skipif(sys.platform in ["win32", "cygwin"], reason="Only works under unix based  systems")
+@mark.skipif(skip_s4_test(), reason="Only works if S4 installed")
 def test_calculate_absorption_profile_rcwa():
     import numpy as np
 
@@ -75,7 +75,7 @@ def test_calculate_absorption_profile_rcwa():
     assert result["absorption"] == approx(parallel_result["absorption"], abs=1e-5)
 
 
-@mark.skipif(sys.platform in ["win32", "cygwin"], reason="Only works under unix based  systems")
+@mark.skipif(skip_s4_test(), reason="Only works if S4 installed")
 def test_pol_rcwa():
     import numpy as np
 
@@ -131,7 +131,7 @@ def test_pol_rcwa():
     assert result_u["absorption"] == approx(0.5*(result_s["absorption"] + result_p["absorption"]))
 
 
-@mark.skipif(sys.platform in ["win32", "cygwin"], reason="Only works under unix based  systems")
+@mark.skipif(skip_s4_test(), reason="Only works if S4 installed")
 def test_arbitrary_pol_rcwa():
     import numpy as np
 
@@ -179,7 +179,7 @@ def test_arbitrary_pol_rcwa():
     assert result["absorption"] == approx(result_s["absorption"])
 
 
-@mark.skipif(sys.platform in ["win32", "cygwin"], reason="Only works under unix based  systems")
+@mark.skipif(skip_s4_test(), reason="Only works if S4 installed")
 def test_rcwa_polygon():
     import numpy as np
 
@@ -241,7 +241,7 @@ def test_rcwa_polygon():
     assert result_polygon["absorption"] == approx(result_square["absorption"], abs=0.001)
 
 
-@mark.skipif(sys.platform in ["win32", "cygwin"], reason="Only works under unix based  systems")
+@mark.skipif(skip_s4_test(), reason="Only works if S4 installed")
 @mark.parametrize("pol", ['s', 'p', 'u'])
 @mark.parametrize("angle", [0, 60])
 def test_tmm_rcwa_structure_comparison(pol, angle):
@@ -285,7 +285,7 @@ def test_tmm_rcwa_structure_comparison(pol, angle):
     assert np.sum(rcwa_result['A_per_layer'], 1) + rcwa_result['R'] + rcwa_result['T'] == approx(1)
 
 
-@mark.skipif(sys.platform in ["win32", "cygwin"], reason="Only works under unix based  systems")
+@mark.skipif(skip_s4_test(), reason="Only works if S4 installed")
 @mark.parametrize("pol", ['s', 'p', 'u'])
 @mark.parametrize("angle", [0, 60])
 def test_tmm_rcwa_structure_profile_comparison(pol, angle):