Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop PDD solver if not convergence. Close #51 . #111

Merged
merged 1 commit into from
May 18, 2020
Merged

Stop PDD solver if not convergence. Close #51 . #111

merged 1 commit into from
May 18, 2020

Conversation

dalonsoa
Copy link
Collaborator

Close #51.

Stops the execution of the script if the maximum number of iterations are reached in the PDD solver. This avoids the problem of a user not realising of the information in the terminal that warns about this.

Reaching the maximum number of iterations nearly always means that the solver is not converging. Things might go wrong if the relative tolerance is reached, but that is sometimes acceptable, so the solver is not stoped in this case. .

@dalonsoa dalonsoa requested a review from phoebe-p May 17, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop PDD solver if there is no convergence
2 participants