New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change layer absorption calculation for BL optics #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #213 +/- ##
========================================
Coverage 45.84% 45.85%
========================================
Files 84 84
Lines 9091 9100 +9
========================================
+ Hits 4168 4173 +5
- Misses 4923 4927 +4
Continue to review full report at Codecov.
|
dalonsoa
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change - instead of integrating over the differentiated absorption, calculate the total absorption analytically. If you have large position spacing and high absorption, the integrated absorption calculated from the absorption profile can be quite off and sometimes > 1. Of course, this way you can get a discrepancy between the EQE (or anything calculated using the absorption profile) and the absorption per layer, but at least the total layer absorption will be correct and this way you can check if you need to use different depth spacing. This is similar to the current approach for the TMM and RCWA methods, which use the power calculated per layer explicitly rather than integrating the absorption profile.