New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes: n/k database, updating examples, bugs in Cauchy model and material parameters #218
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #218 +/- ##
========================================
Coverage 45.85% 45.86%
========================================
Files 84 84
Lines 9100 9101 +1
========================================
+ Hits 4173 4174 +1
Misses 4927 4927
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! Well spotted errors and updates.
x_eV = 1240 / x | ||
|
||
N = self.An + self.Bn / (x / 1000.) ** 2 + self.Cn * (x / 1000.) ** 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering the severity of the error, it suggests this model has not been used that often or someone should have spotted the mistake long ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I tried to actually use it and it was immediately obvious that something was wrong, but that was the first time I (and maybe anyone) had actually tried to use it...
@@ -15,7 +15,7 @@ | |||
Entry = namedtuple('Entry',['id','shelf','book','page']) | |||
|
|||
# Check latest available database in https://refractiveindex.info/download.php | |||
_riiurl = "https://refractiveindex.info/download/database/rii-database-2018-07-01.zip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish there were a more programatic way of checking the database data and fetching the last version. Hardcoding it looks a bit hacky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There probably is, I just haven't looked into it! I will leave it like this now but will have a look to see if there is a more elegant way I can do it.
…ing of relative_permittivity
Few minor fixes:
relative_dielectric_constant
rather thanrelative_permittivity
.relative_dielectric_constant
is never actually used by Solcore (unlikerelative_permittivity
) and as far as I understand it is the same thing anyway. This means that if you used Si and Ge you had to set this parameter manually, which seems unnecessary given that it is well-known, so I have changed these entries torelative_permittivity
.short_circuit_pdd