Clean up deploy process #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #228 +/- ##
========================================
Coverage 45.76% 45.76%
========================================
Files 84 84
Lines 9096 9096
========================================
Hits 4163 4163
Misses 4933 4933 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
phoebe-p
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
I do not have any comments on this (since I do not understand it very well...) but I was wondering, maybe it would also be possible to build wheels for S4. I think I tried this in the past and couldn't get it to work but I think at least on Ubuntu and MacOS it should be possible. Not something to do before we merge this because this is obviously a big improvement in terms of installing Solcore with the PDD solver, but I will look into it for RayFlare.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the build and deploy to PyPI process and update de documentation now that we have binary wheels for Windows.
Every push to any branch will trigger the building process, uploading the created wheels as artefacts and therefore making them available for anyone to try. Additionally, when pushing tags, the wheels will be uploaded to PyPI.