Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] #226 Using reference comparison with literal values #230

Merged

Conversation

Abelarm
Copy link
Contributor

@Abelarm Abelarm commented Oct 12, 2022

Fixing the #226

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #230 (b27e7d8) into develop (b8133b9) will not change coverage.
The diff coverage is 36.36%.

@@           Coverage Diff            @@
##           develop     #230   +/-   ##
========================================
  Coverage    45.76%   45.76%           
========================================
  Files           84       84           
  Lines         9096     9096           
========================================
  Hits          4163     4163           
  Misses        4933     4933           
Impacted Files Coverage Δ
solcore/analytic_solar_cells/QE.py 6.18% <0.00%> (ø)
solcore/poisson_drift_diffusion/QWunit.py 14.35% <0.00%> (ø)
solcore/quantum_mechanics/kp_QW.py 4.50% <0.00%> (ø)
solcore/units_system/units_system.py 73.54% <ø> (ø)
solcore/absorption_calculator/absorption_QW.py 79.53% <100.00%> (ø)
solcore/quantum_mechanics/high_level_kp_QW.py 33.82% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phoebe-p phoebe-p merged commit feed5d2 into qpv-research-group:develop Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants