Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register short circuit solver #234

Merged
merged 4 commits into from Nov 5, 2022
Merged

Conversation

dalonsoa
Copy link
Collaborator

@dalonsoa dalonsoa commented Nov 5, 2022

Adds the registry for the short circuit solvers and update docstrings for the short_circuit_pdd function

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #234 (de18f91) into develop (1f93945) will increase coverage by 0.05%.
The diff coverage is 76.62%.

@@             Coverage Diff             @@
##           develop     #234      +/-   ##
===========================================
+ Coverage    46.01%   46.07%   +0.05%     
===========================================
  Files           85       85              
  Lines         9118     9133      +15     
===========================================
+ Hits          4196     4208      +12     
- Misses        4922     4925       +3     
Impacted Files Coverage Δ
solcore/solar_cell_solver.py 70.80% <37.50%> (-0.27%) ⬇️
...poisson_drift_diffusion/DriftDiffusionUtilities.py 86.16% <78.16%> (-0.31%) ⬇️
solcore/registries.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dalonsoa dalonsoa merged commit 3719ea9 into develop Nov 5, 2022
@dalonsoa dalonsoa deleted the register_short_circuit_solver branch November 5, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant