Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to deal with unphysical results in incoherent calculations for incident n > 1 #237

Merged
merged 7 commits into from
Nov 30, 2022
Merged

Fix to deal with unphysical results in incoherent calculations for incident n > 1 #237

merged 7 commits into from
Nov 30, 2022

Commits on Nov 11, 2022

  1. fix to deal with unphysical results in incoherent calculations for n_… 

    …inc > 1
    @phoebe-p
    phoebe-p committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    bf441e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. fix mistake in incorrectly scaled incoherent absorption profile calcu… 

    …lations
    @phoebe-p
    phoebe-p committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    36e8a4d View commit details
    Browse the repository at this point in the history

  2. remove debugging print statement:

    @phoebe-p
    phoebe-p committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    8fd59d2 View commit details
    Browse the repository at this point in the history

  3. older setuptools version to try to fix failing tests

    @phoebe-p
    phoebe-p committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    09e2744 View commit details
    Browse the repository at this point in the history

  4. fix divide by zero error in test_beer_lambert. update test for additi… 

    …onal argument
    @phoebe-p
    phoebe-p committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    5af4874 View commit details
    Browse the repository at this point in the history

  5. fix spacing 

    Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
    @phoebe-p @dalonsoa
    phoebe-p and dalonsoa committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    9b3b7ac View commit details
    Browse the repository at this point in the history

  6. fix spacing 

    Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
    @phoebe-p @dalonsoa
    phoebe-p and dalonsoa committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    bf03de5 View commit details
    Browse the repository at this point in the history