Implement heterojunction in depletion approximation and fix build issues #256

phoebe-p · 2023-05-26T01:36:27Z

add documentation for installation without PDD, either from PyPI or from local source.

codecov · 2023-05-26T01:42:24Z

Codecov Report

Merging #256 (47ec48c) into develop (4f1b2cf) will increase coverage by 0.16%.
The diff coverage is 57.14%.

@@             Coverage Diff             @@
##           develop     #256      +/-   ##
===========================================
+ Coverage    57.08%   57.25%   +0.16%     
===========================================
  Files          103      104       +1     
  Lines        11633    11690      +57     
===========================================
+ Hits          6641     6693      +52     
- Misses        4992     4997       +5

Impacted Files	Coverage Δ
solcore/material_data/InGaAs-Material/test.py	`0.00% <0.00%> (ø)`
...re/analytic_solar_cells/depletion_approximation.py	`100.00% <100.00%> (ø)`

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

iclned · 2023-07-20T01:29:16Z

Build issues on Windows are fixed and heterojunction model functionality implemented for the depletion approximation.

…it of the following: - add functionality to allow heterojunctions in the depletion approximation (i.e. do not throw an error with a heterojunction) - 🐛 fix issue where the depletion width in the depletion approximation could be wider than the relevant junction region - 🏁 💚 fix Windows build in build_deploy_wheels, and fig issue where Windows test did not run but also did not throw an error in GitHub Actions - 🐧 🍎 fix S4 build in MacOS/Linux - add ability to install without the PDD solver (locally or from PyPI) - 📝 update docs with instructions for the above

- Add test for case where depletion width > region width - Remove testing of examples in Windows (this did not run in GitHub Actions anyway, so removing explicitly so it's clear the examples are not being run on Windows) - Restore test for exceptions in depletion_approximation

phoebe-p mentioned this pull request May 26, 2023

Tests do not seem to run in Windows in GitHub Actions #257

Closed

phoebe-p requested review from iclned and dalonsoa July 20, 2023 00:24

iclned approved these changes Jul 20, 2023

View reviewed changes

phoebe-p force-pushed the heterojunction branch from 03cb8a9 to 8cc6074 Compare July 20, 2023 04:01

phoebe-p removed the request for review from dalonsoa July 20, 2023 04:03

phoebe-p added 2 commits July 24, 2023 13:41

try to fix incorrect coverage issue

954b412

phoebe-p force-pushed the heterojunction branch from 8bd5390 to 47ec48c Compare July 24, 2023 05:18

phoebe-p merged commit c96592f into develop Jul 24, 2023
52 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement heterojunction in depletion approximation and fix build issues #256

Implement heterojunction in depletion approximation and fix build issues #256

phoebe-p commented May 26, 2023 •

edited

codecov bot commented May 26, 2023 •

edited

iclned commented Jul 20, 2023

Implement heterojunction in depletion approximation and fix build issues #256

Implement heterojunction in depletion approximation and fix build issues #256

Conversation

phoebe-p commented May 26, 2023 • edited

codecov bot commented May 26, 2023 • edited

Codecov Report

iclned commented Jul 20, 2023

phoebe-p commented May 26, 2023 •

edited

codecov bot commented May 26, 2023 •

edited