Fix unexpected target temp in fan and auto mode #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqaatw
reviewed
Dec 7, 2022
|
Additionally, if you believe that this PR indeed addresses the issue mentioned on the FAQ section of the readme, you can also delete those texts. |
qqaatw
reviewed
Dec 8, 2022
Co-authored-by: Li-Huai (Allan) Lin <qqaatw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As the issue mentioned in #35, the Jci Hitachi doesn't return a target temperature for auto and fan mode in some AC device, this makes the history plot shows unexpected, huge peak for the
target temperatureattributes.Fixes #35
Goal
Provide a workaround for this issue, the minimum requirement is to make the history plots could be readable.
Method
65535and the mode is auto or fan