Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return None if pm25_value is unsupported. #47

Merged
merged 3 commits into from
May 7, 2023
Merged

Return None if pm25_value is unsupported. #47

merged 3 commits into from
May 7, 2023

Conversation

RiANOl
Copy link
Contributor

@RiANOl RiANOl commented May 7, 2023

To fix #45

@qqaatw
Copy link
Owner

qqaatw commented May 7, 2023

We need to fix this issue holistically not just the sensor in question, let me think about it.

@RiANOl
Copy link
Contributor Author

RiANOl commented May 7, 2023

Sure, take your time :)

qqaatw
qqaatw reviewed May 7, 2023
View reviewed changes
Copy link
Owner

@qqaatw qqaatw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Can you please apply the change to these entities also:

  • JciHitachiPowerConsumptionSensorEntity
  • JciHitachiIndoorHumiditySensorEntity
  • JciHitachiIndoorTemperatureSensorEntity

Thank you for your contribution.

custom_components/jcihitachi_tw/sensor.py Outdated Show resolved Hide resolved
qqaatw
qqaatw approved these changes May 7, 2023
View reviewed changes
Copy link
Owner

@qqaatw qqaatw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qqaatw qqaatw merged commit c468ce5 into qqaatw:master May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qqaatw qqaatw qqaatw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pm25_value could be "unsupported" if dehumidifier didn't have pm2.5 sensor.
2 participants
@RiANOl @qqaatw