Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(climate): Support more horizontal swing #53

Merged
merged 2 commits into from
Jul 12, 2023
Merged

feat(climate): Support more horizontal swing #53

merged 2 commits into from
Jul 12, 2023

Conversation

sykuang
Copy link
Contributor

@sykuang sykuang commented Jul 11, 2023 •
edited by qqaatw
Loading

fixes #52

Support following customized swing mode

  • "Horizontal Leftmost"
  • "Horizontal Middle Left"
  • "Horizontal Central"
  • "Horizontal Middle Right"
  • "Horizontal Rightmost"
  • "Horizontal Leftmost + Vertical Swing"
  • "Horizontal Middle Left + Vertical Swing"
  • "Horizontal Central + Vertical Swing"
  • "Horizontal Middle Right + Vertical Swing"
  • "Horizontal Rightmost + Vertical Swing"

qqaatw
qqaatw reviewed Jul 11, 2023
View reviewed changes
Copy link
Owner

@qqaatw qqaatw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Does it work locally on your end?

I don't have a Hitachi device that equips this feature so I can't test it myself. If someone reports issues with this change the PR may get reverted, sorry.

custom_components/jcihitachi_tw/climate.py Show resolved Hide resolved
custom_components/jcihitachi_tw/climate.py Outdated Show resolved Hide resolved
custom_components/jcihitachi_tw/climate.py Outdated Show resolved Hide resolved
@sykuang
Copy link
Contributor Author

sykuang commented Jul 12, 2023

Thanks for your contribution. Does it work locally on your end?

I don't have a Hitachi device that equips this feature so I can't test it myself. If someone reports issues with this change the PR may get reverted, sorry.

I conducted a test on my air conditioner at home and it appears to be functioning properly.

@qqaatw qqaatw merged commit 65f6224 into qqaatw:master Jul 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qqaatw qqaatw qqaatw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

如何控制冷氣導風板方向
2 participants
@sykuang @qqaatw