Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex:class名の数値を繋ぐハイフンを変更する機能 #270

Closed
qrac opened this issue Mar 2, 2020 · 4 comments
Closed

Flex:class名の数値を繋ぐハイフンを変更する機能 #270

qrac opened this issue Mar 2, 2020 · 4 comments

Comments

@qrac
Copy link
Owner

qrac commented Mar 2, 2020

.is-mobile-12 などのclass名を別の命名規則に変更する場合に機能が足りない。

.hp_flex_mb1 にしようとしても .hp_flex_mb-1 となり、ハイフンが変更できない。ハイフンを変数で変更する機能を追加する。

Before

@include generate-style($option-generate-style-flex) {
  #{$modifier-flex}#{$suffix-flex-grow},
  #{$modifier-flex-mobile}#{$suffix-flex-grow} {
    @include musubii-style-flex-grow();
  }
  @for $i from 1 through $flex-split {
    #{$modifier-flex}-#{$i},
    #{$modifier-flex-mobile}-#{$i} {
      @include musubii-style-flex-split($i);
    }
  }
  #{$modifier-flex}#{$suffix-flex-full},
  #{$modifier-flex-mobile}#{$suffix-flex-full} {
    @include musubii-style-flex-full();
  }
  #{$modifier-flex}#{$suffix-flex-auto},
  #{$modifier-flex-mobile}#{$suffix-flex-auto} {
    @include musubii-style-flex-auto();
  }
}
@qrac
Copy link
Owner Author

qrac commented Mar 2, 2020

After

@include generate-style($option-generate-style-flex) {
  #{$modifier-flex}#{$suffix-flex-grow},
  #{$modifier-flex-mobile}#{$suffix-flex-grow} {
    @include musubii-style-flex-grow();
  }
  @for $i from 1 through $flex-split {
    #{$modifier-flex}#{$suffix-flex-pipe}#{$i},
    #{$modifier-flex-mobile}#{$suffix-flex-pipe}#{$i} {
      @include musubii-style-flex-split($i);
    }
  }
  #{$modifier-flex}#{$suffix-flex-full},
  #{$modifier-flex-mobile}#{$suffix-flex-full} {
    @include musubii-style-flex-full();
  }
  #{$modifier-flex}#{$suffix-flex-auto},
  #{$modifier-flex-mobile}#{$suffix-flex-auto} {
    @include musubii-style-flex-auto();
  }
}

@qrac
Copy link
Owner Author

qrac commented Mar 2, 2020

ビルド済のCSSに変更はない。

@qrac
Copy link
Owner Author

qrac commented Mar 2, 2020

masterに反映。

@qrac
Copy link
Owner Author

qrac commented Mar 2, 2020

v7.0.1に反映。

@qrac qrac closed this as completed Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant