Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wanted: test that components handle known and unknown fields #26

Open
dustmop opened this issue Sep 3, 2020 · 0 comments
Open

wanted: test that components handle known and unknown fields #26

dustmop opened this issue Sep 3, 2020 · 0 comments

Comments

@dustmop
Copy link
Contributor

dustmop commented Sep 3, 2020

By modifying the data returned by tests/mock_loader.py, we should be able to show that constructed dataset components, like structure and meta, will be assigned fields from their list of known fields. See their initializers in qri/dataset.py. We should have tests that verify they get this state, show it when stringified, and will not have any unknown fields assigned to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant