Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta should be able to handle arbitrary fields #28

Open
dustmop opened this issue Sep 3, 2020 · 0 comments
Open

meta should be able to handle arbitrary fields #28

dustmop opened this issue Sep 3, 2020 · 0 comments

Comments

@dustmop
Copy link
Contributor

dustmop commented Sep 3, 2020

Issue #26 leaves out an important detail: the meta component should be able to hold any arbitrary field value. Any field name not in its "known" list should be put into a generic map of string->string. See the declaration of qri's Meta struct at https://github.com/qri-io/dataset/blob/master/meta.go which has a private meta field for this purpose. Note how this is handled using the fill package which looks for an ArbitrarySetter interface, which is defined alongside the Meta struct.

This python package does not support this behavior, but it should, and needs accompanying tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant