refactor(config): RPC > HTTP & API for config #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5
approved these changes
Mar 4, 2021
lib/config.go
Outdated
| @@ -55,37 +57,40 @@ func (m *ConfigMethods) GetConfig(p *GetConfigParams, res *[]byte) (err error) { | |||
| if p.Field != "" { | |||
| encode, err = cfg.Get(p.Field) | |||
| if err != nil { | |||
| return fmt.Errorf("error getting %s from config: %s", p.Field, err) | |||
| return nil, fmt.Errorf("error getting %s from config: %s", p.Field, err) | |||
There was a problem hiding this comment.
gotta wrap them errors:
Suggested change
| return nil, fmt.Errorf("error getting %s from config: %s", p.Field, err) | |
| return nil, fmt.Errorf("error getting %s from config: %w", p.Field, err) |
b5
requested changes
Mar 4, 2021
lib/config.go
Outdated
| return checkRPCError(m.inst.rpc.Call("ConfigMethods.GetConfig", p, res)) | ||
| func (m *ConfigMethods) GetConfig(ctx context.Context, p *GetConfigParams) ([]byte, error) { | ||
| if m.inst.http != nil { | ||
| return nil, fmt.Errorf("config is not supported across nodes") |
There was a problem hiding this comment.
on second thought, this error is the one users will when they try to qri config get while running qri connect somewhere else. We should make this a standard error ErrUnsupportedRPC so we can capture it with errors.Is & present a clearer error for CLI users ("this could mean you're running qri connect in another terminal")
Arqu
force-pushed
the
arqu/rth_config
branch
2 times, most recently
from
452e316
to
4ae9b66
Compare
Arqu
commented
Mar 5, 2021
lib/lib_test.go
Outdated
| @@ -187,7 +187,7 @@ func TestReceivers(t *testing.T) { | |||
| inst := &Instance{node: node, cfg: cfg} | |||
|
|
|||
| reqs := Receivers(inst) | |||
| expect := 10 | |||
| expect := 9 | |||
There was a problem hiding this comment.
Before merging, need to rebase and drop this to 8.
dustmop
approved these changes
Mar 5, 2021
AFAIK No just checked the codebase real quick, also Desktop communicates API only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1675