Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The list of DDA experimental releases is not loading on Linux #159

Closed
adequacy1 opened this issue Jul 1, 2024 · 20 comments
Closed

The list of DDA experimental releases is not loading on Linux #159

adequacy1 opened this issue Jul 1, 2024 · 20 comments
Labels
wontfix This will not be worked on

Comments

@adequacy1
Copy link

adequacy1 commented Jul 1, 2024

Maintainer Edit

The only current solution for playing experimental on Linux is going to settings and setting "Number of releases to request" to a high number like 100, 500, This will make Catapult load more and thus older valid Linux releases.

There is nothing else we (Catapult) can do to actually fix this issue, CDDA tiles linux builds are currently broken upstream (check out CleverRaven/Cataclysm-DDA#74858 for more info).

Original post

The list of DDA experimental releases is not loading. Other versions of Cataclysm - the download works.
Linux version.

@stasalcatraz

This comment was marked as duplicate.

@iamnickdavis
Copy link

Same issue on latest Manjaro and Ubuntu

@teackot
Copy link

teackot commented Jul 3, 2024

The reason is that there are actually no releases since June 27th due to some build error. See this issue

@adequacy1
Copy link
Author

adequacy1 commented Jul 4, 2024

Indeed, another release appeared today (2024-07-03-2146).

@NazarYermolenko

This comment was marked as off-topic.

@NazarYermolenko
Copy link

NazarYermolenko commented Jul 12, 2024

The issue is based that substring of experimental builds doesn't exists at this moment for Linux platform:

"dda-experimental-linux": {
		"field": "name",
		"substring": "cdda-linux-tiles-x64", <-- doesn't exists in build names
#		"substring": " cdda-linux-curses-x64" <-- not sure but i guess it's a correct one haven't tested, haven't work before with godot
	}

Actually:
We have build names:

Substring: cdda-linux-tiles-x64
Field: cdda-android-bundle-2024-07-12-2131.aab
Substring: cdda-linux-tiles-x64
Field: cdda-android-x32-2024-07-12-2131.apk
Substring: cdda-linux-tiles-x64
Field: cdda-android-x64-2024-07-12-2131.apk
Substring: cdda-linux-tiles-x64
Field: cdda-linux-curses-x64-2024-07-12-2131.tar.gz
Substring: cdda-linux-tiles-x64
Field: cdda-osx-curses-universal-2024-07-12-2131.dmg
Substring: cdda-linux-tiles-x64
Field: cdda-osx-tiles-universal-2024-07-12-2131.dmg
Substring: cdda-linux-tiles-x64
Field: cdda-windows-tiles-sounds-x64-2024-07-12-2131.zip
Substring: cdda-linux-tiles-x64
Field: cdda-windows-tiles-sounds-x64-msvc-2024-07-12-2131.zip
Substring: cdda-linux-tiles-x64
Field: cdda-windows-tiles-x64-2024-07-12-2131.zip
Substring: cdda-linux-tiles-x64

Completed PR: #161 < --- please test

Tested: Game is not starting from Godot for last experimental release

@NazarYermolenko
Copy link

Next point the last experimental release on official vebsite was
cdda-linux-tiles-x64-2024-06-26-1623.tar.gz

But the Catapult fetch last 10 releases which doesn't contain cdda-linux-tiles-x64 probably we should increase count of featched releases till 100 and display only 10 ones

@NazarYermolenko
Copy link

I'll prepare another PR tomorrow :)

@NazarYermolenko
Copy link

NazarYermolenko commented Jul 13, 2024

Fixed in #162 @AriaMoradi, @qrrk please review

@NazarYermolenko
Copy link

Closed as count of releases to request can be changed in settings...

@AriaMoradi
Copy link
Collaborator

Closed as count of releases to request can be changed in settings...

What's the problem here?

@NazarYermolenko
Copy link

@AriaMoradi the problem was that CDDA experimental releases wasn't loading for Linux systems, so I performed the investigation and opened couple of requests to fix that, than I understood that issue can be fixed just by increasing releases to fetch count in Catapult settings. So, I closed all opened PR's, and I guess the issue can be also closed.

@AriaMoradi AriaMoradi changed the title The list of DDA experimental releases is not loading The list of DDA experimental releases is not loading on Linux Jul 16, 2024
@failboat78
Copy link

The users are not gonna know that - you should make it default to some value that works.

@NazarYermolenko
Copy link

The users are not gonna know that - you should make it default to some value that works.

Thanks, will create PR.

@NazarYermolenko
Copy link

@failboat78, @qrrk, @AriaMoradi Created PR to fix issue #166

@AriaMoradi AriaMoradi added the wontfix This will not be worked on label Jul 17, 2024
@ISuckM8
Copy link

ISuckM8 commented Jul 20, 2024

Why not just add an option to get the last 10 working releases if you're on Linux? Forcing the user to increase the fetch releases from 10 to 100 makes them wait for an increasingly long period of time for only two or so new releases. This shouldn't be all that difficult, however I'm not good with CPP and only ever touched C#, python and similar languages so I don't think I'd be able to do it myself.

@ingles98
Copy link

ingles98 commented Jul 21, 2024

Latest releases are working now. It still is rather odd that it counts every release instead of counting every OS/platform specific build.
If 100 releases fail for Linux specifically we wont be able to list anything on Catapult.

@qrrk
Copy link
Owner

qrrk commented Jul 21, 2024

This comes down to GitHub API. As far as it is concerned, a release is anything that goes on the Releases page of a project, regardless of whether it has any artifacts for a given platform (or any artifacts at all, even). There is no way to request only releases relevant to a specific platform (and to my knowledge there is no way for project maintainers even to provide that information to the system).

@AriaMoradi
Copy link
Collaborator

CleverRaven/Cataclysm-DDA#74858 was closed, the issue is resolved now.

@AriaMoradi AriaMoradi unpinned this issue Jul 25, 2024
@ISuckM8
Copy link

ISuckM8 commented Jul 25, 2024

This comes down to GitHub API. As far as it is concerned, a release is anything that goes on the Releases page of a project, regardless of whether it has any artifacts for a given platform (or any artifacts at all, even). There is no way to request only releases relevant to a specific platform (and to my knowledge there is no way for project maintainers even to provide that information to the system).

Can't you get every release and check if it has 'linux' in its name?

Repository owner locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

10 participants