Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash using minitest 5.16.0 #91

Closed
greeneca opened this issue Jun 17, 2022 · 3 comments
Closed

Crash using minitest 5.16.0 #91

greeneca opened this issue Jun 17, 2022 · 3 comments

Comments

@greeneca
Copy link
Contributor

Using m with minitest 5.16.0 crashes because Minitest.seed was added and is only populated when options are parsed. This doesn't happen when using m so it needs to be populated manually.

Will open a PR with a fix soon.
greeneca added a commit to greeneca/m that referenced this issue Jun 17, 2022
@greeneca
qrush#91 manually set Minitest.seed
5f6e6ee
zamith pushed a commit that referenced this issue Jun 22, 2022
@greeneca
#91 manually set Minitest.seed (#92)
8b9783e
@zamith
Copy link
Collaborator

zamith commented Jun 22, 2022

Thanks! Merged it.

@zamith zamith closed this as completed Jun 22, 2022
@dgsangoma
Copy link

Any plans to release a new version that includes this fix?

@stevendaniels
Copy link

@gi - any update on when the new version will be released?

felixonmars added a commit to felixonmars/byebug that referenced this issue Oct 22, 2022
@felixonmars
Manually set Minitest.seed for minitest 5.16 compatibility
f9b7e9b 
Ref: qrush/m#91
@felixonmars felixonmars mentioned this issue Oct 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zamith @stevendaniels @greeneca @dgsangoma