Skip to content

Commit

Permalink
Add OPTIONS parameter to qt5_add_translation
Browse files Browse the repository at this point in the history
With this it is possible to pass additional parameters to the lrelease
command

Change-Id: I8f552f1b965d6c03a9115753438d841aef181315
Task-number: QTBUG-44323
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: André Klitzing <aklitzing@gmail.com>
Reviewed-by: Kai Pastor <dg0yt@darc.de>
Reviewed-by: David Faure <david.faure@kdab.com>
  • Loading branch information
krf committed Jan 12, 2018
1 parent 2eefc8e commit 9f3dba2
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
11 changes: 9 additions & 2 deletions src/linguist/Qt5LinguistToolsMacros.cmake
Expand Up @@ -82,7 +82,14 @@ endfunction()


function(QT5_ADD_TRANSLATION _qm_files)
foreach(_current_FILE ${ARGN})
set(options)
set(oneValueArgs)
set(multiValueArgs OPTIONS)

cmake_parse_arguments(_LRELEASE "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})
set(_lrelease_files ${_LRELEASE_UNPARSED_ARGUMENTS})

foreach(_current_FILE ${_lrelease_files})
get_filename_component(_abs_FILE ${_current_FILE} ABSOLUTE)
get_filename_component(qm ${_abs_FILE} NAME_WE)
get_source_file_property(output_location ${_abs_FILE} OUTPUT_LOCATION)
Expand All @@ -95,7 +102,7 @@ function(QT5_ADD_TRANSLATION _qm_files)

add_custom_command(OUTPUT ${qm}
COMMAND ${Qt5_LRELEASE_EXECUTABLE}
ARGS ${_abs_FILE} -qm ${qm}
ARGS ${_LRELEASE_OPTIONS} ${_abs_FILE} -qm ${qm}
DEPENDS ${_abs_FILE} VERBATIM
)
list(APPEND ${_qm_files} ${qm})
Expand Down
2 changes: 1 addition & 1 deletion tests/auto/cmake/test_add_translation_macro/CMakeLists.txt
Expand Up @@ -17,7 +17,7 @@ set(my_srcs myi18nobject.cpp)

include_directories("${CMAKE_CURRENT_SOURCE_DIR}/some_dir")

qt5_add_translation(qm_files myobject_de.ts)
qt5_add_translation(qm_files myobject_de.ts OPTIONS -compress) # play around with OPTIONS

add_executable(test_add_translation ${my_srcs} ${qm_files})
target_link_libraries(test_add_translation ${Qt5Core_LIBRARIES})

0 comments on commit 9f3dba2

Please sign in to comment.