Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages can add commands to types they don't own #36

Open
robotlolita opened this issue Dec 30, 2021 · 0 comments
Open

Packages can add commands to types they don't own #36

robotlolita opened this issue Dec 30, 2021 · 0 comments
Labels
error Something is confusing, misbehaving, or harmful. s:1 moderate This is bad. We should deal with this as soon as possible.

Comments

@robotlolita
Copy link
Contributor

This is an intended behaviour, so the aim of this ticket is not to remove it, but to add a bit more of controls to it so users can consent to it being done. Because packages can add commands to any type, they may be able to trick users into executing code that they would otherwise not do.

The issue is already mitigated with the use of capabilities. Even though, in theory, attackers can add commands to any types, and try to trick users into invoking their version of the command (likely a typo), they are still restricted in what they can do; they can do exactly what the capabilities granted to their package allows them to do. This reduces the amount of interesting attacks that can be done.

@robotlolita robotlolita added error Something is confusing, misbehaving, or harmful. s:1 moderate This is bad. We should deal with this as soon as possible. labels Dec 30, 2021
@robotlolita robotlolita added this to the First stable release milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error Something is confusing, misbehaving, or harmful. s:1 moderate This is bad. We should deal with this as soon as possible.
Projects
None yet
Development

No branches or pull requests

1 participant