Breaking change: new cartridge format #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotlolita
added
c:kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally implements the cartridge changes that had been on the backlog for a while. It also removes code for parsing earlier versions of the cartridge format. The older formats had no real usage and thus don't need to be supported. The format introduced here must be supported for the whole life of Kate.
The patch is not complete—there are a few pending changes required for other in-progress patches (new capabilities and the store). But the format will not really change significantly. The limit for cartridge sizes was bumped to 1.4GB, but that still needs to be fully loaded in memory with the current implementation. Support for streaming will be added directly in LJT.
Note that there's no intended upgrade path from v0.26 to v0.28. Kate does not currently have any user base, so this is fine, but it means updating to 0.28 requires first deleting the entire Kate database and starting fresh.