Support requests to navigating to external URLs #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotlolita
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very initial patch to allow cartridges to open external URLs (in a similar fashion to
shell.open(url)APIs that other platforms offer). Here we take some care to inform the user of the security and privacy implications of that action, and give them some information about the destination so they can make some risk assessment. However, due to the nature of Kate's cartridges, web browsers, and the internet, actual informed consent is not possible, and the threat of data exfiltration cannot be fully mitigated.This patch also adds initial support for contextual capabilities. There will be separate patches to allow viewing and managing these capabilities; currently they're just auto-granted when the cartridge is installed.
There will also be future patches to implement proper auditing and quota supervising of the feature, that are specified here but not implemented yet.