Introduce a fairness supervisor #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotlolita
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a "fairness supervisor". Right now this is pretty straight-forward, and just checks that a cartridge is not abusing modal dialogs to prevent users from using the device (since modal dialogs always stack on top of the current foreground screen). This means that from now on cartridges will only be able to show a modal dialog if they are the screen on foreground and if they are not showing another modal dialog (it shouldn't be possible with the first restriction in any case).
There may be more fairness quotas applied later, particularly once Kate supports multiple processes, as there we'd like to ensure that no cartridge hogs the entire device to itself.