Make keyboard input bridge more flexible #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different engines listen to keyboard events in different elements (e.g.: Bitsy uses document, Ren'py uses window, Godot uses the canvas it's rendering to), so the element we dispatch events to needs to be configurable. This patch introduces this in a backwards compatible way. A new keyboard-input-proxy-v2 bridge works like input-proxy, but takes in an additional "selector" parameter, which can be "window", "document", or a CSS selector to find an element on the page (we poll for up to 60 seconds). Uses of the legacy input-proxy bridge are converted to the new one at runtime, but parsing support for the older value will always be kept.
robotlolita
added
c:kernel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different engines listen to keyboard events in different elements (e.g.: Bitsy uses document, Ren'py uses window, Godot uses the canvas it's rendering to), so the element we dispatch events to needs to be configurable.
This patch introduces this in a backwards compatible way. A new keyboard-input-proxy-v2 bridge works like input-proxy, but takes in an additional "selector" parameter, which can be "window", "document", or a CSS selector to find an element on the page (we poll for up to 60 seconds). Uses of the legacy input-proxy bridge are converted to the new one at runtime, but parsing support for the older value will always be kept.