Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations uptaded #12

Closed
herrvigg opened this issue Jun 21, 2018 · 9 comments
Closed

Translations uptaded #12

herrvigg opened this issue Jun 21, 2018 · 9 comments
Labels
legacy PR Legacy PR imported from original repo

Comments

@herrvigg
Copy link
Collaborator

Issue by pedro-mendonca
Thursday Jan 29, 2015 at 09:46 GMT
Originally opened as qTranslate-Team/qtranslate-x#12


.pot catalog updated with new strings found.
Portuguese files updated also.


pedro-mendonca included the following code: https://github.com/qTranslate-Team/qtranslate-x/pull/12/commits

@herrvigg herrvigg added the legacy issue Legacy issue imported from original repo label Jun 21, 2018
@herrvigg
Copy link
Collaborator Author

Comment by pedro-mendonca
Thursday Jan 29, 2015 at 11:21 GMT


I've added this commit pedro-mendonca/qtranslate-x@33e97c1 to optimize a string I've corrected before, where I've isolated the 'and' for translation. I think it looks and works better like this, cleaner code.

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Thursday Jan 29, 2015 at 17:40 GMT


Pedro, do you think comma is an international mark the same for all languages? If so, I would then suggest "%s and %s" instead of "%s, %s, %s, %s, %s and %s", just to be flexible on the number of functions listed, which may change later. It is not important, but would probably be even more clean?

@herrvigg
Copy link
Collaborator Author

Comment by pedro-mendonca
Thursday Jan 29, 2015 at 18:25 GMT


I really don't know. Thats why I thought it would be more clear and flexible for each translator to choose the best way to translate it in their language, in portuguese it's more or less like english in this case, %s, %s, %s, %, and %s, but there can be some cases that it fits better only with comas or something else. Of course the translator must understand clearly the statement in english to adapt it as he wish.
From the translator point of view, I can say that a complete sentence with variables (%s) is way more clear to understand the context and the meaning than two separate strings that would be concatenated in php.
Of course the translator MUST respect the number of strings, but I think that is verified in Poedit parsing.

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Friday Jan 30, 2015 at 00:55 GMT


Ok, I realised that if we ever need to change number of %s, we can adjust each po file as well without asking somebody to make a new translation, following whatever pattern will will see, so it is not a big deal. This way is definitely good for any language, while one %s might be indeed a problem for some - you are right.

@herrvigg
Copy link
Collaborator Author

Comment by pedro-mendonca
Friday Jan 30, 2015 at 10:51 GMT


If the number of %s will probably change, of course you will need to update the language files, but that is a lot of unnecessary work.
In that case I definitly go for the whole list in one simple %s, with no descriptive text needed to translate, making it a more technical list.

Instead of "Enable function names compatibility for %s, %s, %s, %s, %s and %s."
Go for "Enable function names compatibility for listed funcions (%s)." where %s is coded without any english text like "func_a; func_b; func_c; func_d**(; func_n)"**.

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Friday Jan 30, 2015 at 16:02 GMT


May be just simply "Enable function name compatibility (%s)."?

@herrvigg
Copy link
Collaborator Author

Comment by pedro-mendonca
Friday Jan 30, 2015 at 16:40 GMT


Yep, thats it. The list in %s of course must only use ; elements, no english, no text to translate.

@herrvigg
Copy link
Collaborator Author

Comment by johnclause
Saturday Jan 31, 2015 at 19:47 GMT


Hi Pedro, yes the number of functions already changed, I added qtrans_generateLanguageSelectCode, so our discussion here was not completely useless 👍

@herrvigg
Copy link
Collaborator Author

Comment by pedro-mendonca
Monday Feb 02, 2015 at 13:44 GMT


👍
Closing this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy PR Legacy PR imported from original repo
Projects
None yet
Development

No branches or pull requests

1 participant