Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ADDRESS_DATA_SIZE to 20 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Earlz
Copy link
Contributor

@Earlz Earlz commented Jul 2, 2019

This updates the address size to 20. Currently there is no address type implemented which consumes more than 20 bytes, so there is no reason to have the address be larger

@xuanyan0x7c7
Copy link

witness_v0_scripthash addresses contain 32 bytes data

@Earlz
Copy link
Contributor Author

Earlz commented Jul 2, 2019

This is true, but another address type requires 64 bytes, and some other witness address types can require a dynamic size. In the prototype right now, only the 20 byte address types are supported (pubkeyhash, scripthash, EVM, x86). I think the proper way to support the larger address types in the future will be to make the UniversalAddressABI structure support a dynamic size for the address. This requires a lot of API changes though, and so I think it can be delayed until v2 (testnet, rather than prototype) of Qtum-x86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants