This repository has been archived by the owner on Jan 13, 2021. It is now read-only.
Fix for ssl issue with where bucket name has dots in it #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekmahawar
commented
Dec 2, 2016
idralyuk
suggested changes
Dec 2, 2016
|
This is just a hack for a ssl library issue with dots, and not actually a dataduct feature change. Had a discussion with @vivek about this, we don't feel there's a test case needed for this in dataduct. Ideally, this fix should be in pyhon ssl and related test case should go in there. Please feel free to comment otherwise. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.