This repository has been archived by the owner on Mar 30, 2023. It is now read-only.
Migration to Swift 3 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace structs with protocols * Rely more on generics for default implementations * Replaces Int with typealias for identifiers * Add more tests and removes those which were superfluous
This also adds a target for macOS
|
Thanks for the contribution!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of the codebase to Swift 3, as well as simplifying project structure by replacing CocoaPods with Carthage (clients of the framework can use both though).
The tag 2.0.0 SHOULD be added to allow installing the framework with either CocoaPods or Carthage.