Reviewing infra some #1033
Merged
Reviewing infra some #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## a-team #1033 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 149 149
Lines 22929 22929
=======================================
Hits 20215 20215
Misses 2714 2714 ☔ View full report in Codecov by Sentry. |
added 2 commits
January 27, 2024 17:18
davidkircos
reviewed
Jan 28, 2024
| name: `${filesSubdomain}.${domain}`, // subdomain you want to use | ||
| type: "A", | ||
| ttl: 300, | ||
| records: [instance.publicIp], |
There was a problem hiding this comment.
Is this reliable? I've heard this can be flaky because the publicIp can change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.