-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make this.app conditional #480
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -142,16 +145,18 @@ export class SheetController { | |||
// add reverse transaction to redo stack | |||
this.redo_stack.push(reverse_transaction); | |||
|
|||
this.app.settings.setInteractionState?.(transaction.cursor); | |||
if (this.app) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably good to add a comment that explains what this does
@@ -180,11 +185,15 @@ export class SheetController { | |||
// add reverse transaction to undo stack | |||
this.undo_stack.push(reverse_transaction); | |||
|
|||
this.app.settings.setInteractionState?.(transaction.cursor); | |||
if (this.app) { | |||
if (transaction.cursor) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right to me!
so the tests pass